Add NodeID to execution options #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the `ExecutionOptions` and `SelectOptions` to allow a `NodeID` for specifying an exact node to query against.
benbjohnson
force-pushed
the
http-query-node-id
branch
from
10a422e to
7d4bea7
Compare
|
Looks fine to me, but @jwilder should take a look at it too. I would say that I think this is leaking a bit too much of the clustering code into the open source version and we should consider how to make the handler more extensible. |
|
@jsternberg I agree it's leaky but I wasn't sure of a better way to do it. The |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request changes the
ExecutionOptionsandSelectOptionsto allow aNodeIDfor specifying an exact node to query against. HTTP support is also added with anode_idfield./cc @jwilder
TODO