Reduce allocations on Query's io.Stringer implementation #6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 but needs a changelog entry. |
|
👍 |
A query's String method is called multiple times per query. This commit ensures all calls to query.String share use of a strings.NewReplacer. This approximately halves the number of allocations for the benchmarked query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
A query's String method can be called multiple times per query. This commit
ensures all calls to query.String share use of a strings.NewReplacer rather than allocating one per call. A
strings.Replaceris safe for concurrent use by multiple goroutines.This approximately halves the number of allocations for the included benchmark.
to