Store shard size on disk statistic #6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-dard
force-pushed
the
jw-shard-size
branch
3 times, most recently
from
5638e3d to
c2535c5
Compare
|
👍 |
| @@ -173,6 +181,8 @@ func (s *Shard) Open() error { | |||
| } | |||
| s.logger.Printf("%s database index loaded in %s", s.path, time.Now().Sub(start)) | |||
|
|
|||
| go s.monitorSize() | |||
There was a problem hiding this comment.
do we have a separate goroutine for monitoring each individual stat? Seems like we should come up with a design where on goroutine gathers all stats directly?
There was a problem hiding this comment.
Just this stat right now. I agree that we need to have a polling model. Unfortunately, we need to rework the monitoring framework quite a bit to allow it it pull stats like this that are too complicated to track in real time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
This PR adds a monitoring goroutine to each shard, which will periodically emit a statistic with the current on-disk size of the shard.
@jwilder
/cc @sparrc