Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some HTTP statistics #6654

Merged
merged 2 commits into from
May 18, 2016
Merged

Add some HTTP statistics #6654

merged 2 commits into from
May 18, 2016

Conversation

e-dard
Copy link
Contributor

@e-dard e-dard commented May 17, 2016 •
edited
Loading

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

We need some extra HTTP-level statistics. This PR adds the following:

  • All HTTP requests resulting in client errors (4xx) are counted up under a clientError key on the _internal database.
  • All HTTP requests resulting in server errors (5xx) are counted up under a serverError key on the _internal database.
  • The number of in-flight write requests are tracked.

/cc @jwilder @121watts

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @gunnaraasen and @joelegasse to be potential reviewers

@dgnorton
Copy link
Contributor

👍 lgtm

@jwilder jwilder added this to the 1.0.0 milestone May 17, 2016
@jwilder
Copy link
Contributor

jwilder commented May 17, 2016

👍

@e-dard e-dard merged commit 887e4ba into master May 18, 2016
@e-dard e-dard deleted the er-http-stat branch May 18, 2016 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0 beta
Development

Successfully merging this pull request may close these issues.
4 participants
@e-dard @mention-bot @dgnorton @jwilder