Remove old cluster code #6604
Merged
Remove old cluster code #6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @e-dard to be a potential reviewer |
| LogQueriesAfter toml.Duration `toml:"log-queries-after"` | ||
| MaxSelectPointN int `toml:"max-select-point"` | ||
| MaxSelectSeriesN int `toml:"max-select-series"` | ||
| MaxSelectBucketsN int `toml:"max-select-buckets"` |
There was a problem hiding this comment.
There is no default or description about what this (MaxSelectBucketsN) does.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
This PR removes the old cluster related code and config options. It also renames the config option to
[coordinator]since some of the options are related to query and write limits and are still needed. Config's that have[cluster]defined will still load and will be converted to[coordinator]for backwards compatibility. These config options will need to be updated before 1.0 release.This also adds back the
PointsWritertimeout config option that was not actually being used byPointsWriter.