Support regex selection in SHOW TAG VALUES for the key #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-4532-show-tag-values-with-regex
branch
2 times, most recently
from
c4c06c1 to
4ed83c9
Compare
jsternberg
force-pushed
the
js-4532-show-tag-values-with-regex
branch
4 times, most recently
from
da63d1b to
6b4f087
Compare
jsternberg
force-pushed
the
js-4532-show-tag-values-with-regex
branch
2 times, most recently
from
99d97bb to
74bf6af
Compare
jsternberg
force-pushed
the
js-4532-show-tag-values-with-regex
branch
3 times, most recently
from
9d89076 to
810150e
Compare
| // SetLiteral represents a set literal. | ||
| type SetLiteral struct { | ||
| Vals []string | ||
| } |
There was a problem hiding this comment.
Should this be a ListLiteral if we're not ensuring uniqueness?
There was a problem hiding this comment.
I wanted this to eventually be an actual set to implement something else, but I think it's reasonable to rename this to ListLiteral until that change is actually done.
|
Minor naming comment otherwise lgtm |
…VALUES
This adds support for using regex expressions in SHOW TAG VALUES when
selecting the key. Also supporting the `!=` operation for the
comparison. Now you can do any of the following:
SHOW TAG VALUES WITH KEY != "region"
SHOW TAG VALUES WITH KEY =~ /region/
SHOW TAG VALUES WITH KEY !~ /region/
It also adds a new SetLiteral AST node that will potentially be used in
the future to allow set operations for other comparisons in the future.
Fixes #4532.
jsternberg
force-pushed
the
js-4532-show-tag-values-with-regex
branch
from
810150e to
9837de7
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4532.