Fix parseFill to check for fill ident before attempting to parse an expression #6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-6543-parse-fill-bad-query
branch
from
294f262 to
632bdb3
Compare
jsternberg
force-pushed
the
js-6543-parse-fill-bad-query
branch
from
632bdb3 to
16abf0a
Compare
jsternberg
force-pushed
the
js-6543-parse-fill-bad-query
branch
from
16abf0a to
58e45b1
Compare
…xpression The previous parseFill would try to parse an expression and only unscan one token when it failed. This caused it to not put back the correct number of tokens with some expression. Now it has been modified to check for the fill ident ahead of time and then use ParseExpr() to parse the call. If the expression fails to parse into a call, it will send an error instead of trying to continue with an invalid parser state. Fixes #6543.
jsternberg
force-pushed
the
js-6543-parse-fill-bad-query
branch
from
58e45b1 to
2c739c0
Compare
|
👍 lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous parseFill would try to parse an expression and only unscan
one token when it failed. This caused it to not put back the correct
number of tokens with some expression.
Now it has been modified to check for the fill ident ahead of time and
then use ParseExpr() to parse the call. If the expression fails to parse
into a call, it will send an error instead of trying to continue with an
invalid parser state.
Fixes #6543.