Move to Go 1.6.2

[rossmcdonald]

Required for all non-trivial PRs

• Rebased/mergable
• Tests pass
• CHANGELOG.md updated
• Sign CLA (if not already signed)

Fixes #6511

[mention-bot]

By analyzing the blame information on this pull request, we identified @e-dard and @mark-rushakoff to be potential reviewers

[jwilder]

Need to update this? https://github.com/influxdata/influxdb/blob/master/package.sh#L70

[jwilder]

Needs a CHANGELOG entry as well.

[corylanou]

There are several instances of GOMAXPROCS being set that can now be removed. On master I see these lines:

$ Ack GOMAXPROCS

cmd/influx_tsm/main.go
70:     fs.BoolVar(&opts.Parallel, "parallel", false, "Perform parallel conversion. (up to GOMAXPROCS shards at once)")
161:            if !isEnvSet("GOMAXPROCS") {
162:                    // Only modify GOMAXPROCS if it wasn't set in the environment
163:                    // This means 'GOMAXPROCS=1 influx_tsm -parallel' will not actually
165:                    runtime.GOMAXPROCS(runtime.NumCPU())
183:    fmt.Printf("Parallel mode enabled (GOMAXPROCS): %s (%d)\n", yesno(opts.Parallel), runtime.GOMAXPROCS(0))

cmd/influx_tsm/README.md
51:Parallel mode enabled (GOMAXPROCS): yes (8)

cmd/influx_tsm/tracker.go
31:             pg:     NewParallelGroup(runtime.GOMAXPROCS(0)),

cmd/influxd/run/command.go
74:     runtime.GOMAXPROCS(runtime.NumCPU())
79:     log.Printf("Go version %s, GOMAXPROCS set to %d", runtime.Version(), runtime.GOMAXPROCS(0))

monitor/go_runtime.go
16:             "GOMAXPROCS": runtime.GOMAXPROCS(-1),

Monitor seems like we want that one (or someone put thought into that I guess). Not sure about influx_tsm, but influxd should get changed.

[jwilder]

@corylanou influx_tsm one should stay as well.

[rossmcdonald]

CHANGELOG updated.

@jwilder Regarding package.sh, that script is no longer used for any of our builds in lieu of build.py. I'm wondering if we should just remove it altogether?

[jwilder]

I'm not really familiar with it. If you're positive it's not used anywhere then we should remove.

[jwilder]

👍 on green.

[rossmcdonald]

@jwilder Should we still remove the GOMAXPROCS references? Or should we just keep them there for now?

[jwilder]

@rossmcdonald Let's leave them there for now.

[rossmcdonald]

I've also updated the appveyor build to use Go 1.6, though I keep getting a failure in stress:

stress_test.go:417: Expected 0 to not be 0

[jwilder]

Maybe try:

diff --git a/stress/stress_test.go b/stress/stress_test.go
index 77e1ae5..a8e3b83 100644
--- a/stress/stress_test.go
+++ b/stress/stress_test.go
@@ -413,8 +413,8 @@ func TestBasicQueryClient_Query(t *testing.T) {
        }

        elapsed := r.Timer.Elapsed()
-       if elapsed == time.Duration(0) {
-               t.Errorf("Expected %v to not be 0", elapsed)
+       if elapsed.Nanoseconds() == 0 {
+               t.Errorf("Expected %v to not be 0", elapsed.Nanoseconds())
        }

 }

[e-dard]

LGTM 👍

[daviesalex]

Production machine change from 0.12 to 0.13 stable:

Every other metric pretty much unchanged. +1!