Fix the CLI not to enter an infinite loop when the liner has an error #6491
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @e-dard to be a potential reviewer |
|
LGTM 👍 |
This also removes the dependency on `os/user` and uses the `HOME` environment variable which is more common on Linux and Mac OS X for customizing the history file location. Removing this import also lets the `influx` binary be cross-compiled as `os/user` relies on cgo.
jsternberg
force-pushed
the
js-cli-infinite-loop
branch
from
7fd5cfc to
2ccbe26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the dependency on
os/userand uses theHOMEenvironment variable which is more common on Linux and Mac OS X for
customizing the history file location.
Removing this import also lets the
influxbinary be cross-compiled asos/userrelies on cgo.