Removing no longer used code in the query engine #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 with a changelog. |
|
Where in the changelog should I put dead code removal? Is that a bugfix or a feature? |
|
I would put it under Bug Fix, as it feels like it should of been removed during a prior commit. But regardless, I don't think it fits under feature. |
jsternberg
force-pushed
the
js-influxql-unused-code
branch
from
cb4058c to
a37e2db
Compare
jsternberg
force-pushed
the
js-influxql-unused-code
branch
from
a37e2db to
9c2e430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.