Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error when an invalid expression is used with aux iterators #6255

Merged
merged 1 commit into from
Apr 7, 2016

Conversation

jsternberg
Copy link
Contributor

The following query was fixed previously:

SELECT 'value' FROM cpu

This ended up hitting the buildExprIterator() code path and was
handled properly. But this query:

SELECT 'value', value FROM cpu

This took a different code path that would trigger a panic because it
triggered a panic instead of an error condition. This code path has now
been modified to trigger an error instead of a panic.

Fixes #6248.

@jsternberg
Copy link
Contributor Author

@benbjohnson

The following query was fixed previously:

    SELECT 'value' FROM cpu

This ended up hitting the `buildExprIterator()` code path and was
handled properly. But this query:

    SELECT 'value', value FROM cpu

This took a different code path that would trigger a panic because it
triggered a panic instead of an error condition. This code path has now
been modified to trigger an error instead of a panic.

Fixes #6248.
@jsternberg jsternberg force-pushed the js-6248-strings-in-select-panic branch from 9963e18 to d176c8b Compare April 7, 2016 15:01
@benbjohnson
Copy link
Contributor

👍

@jsternberg jsternberg merged commit 61aa298 into master Apr 7, 2016
@jsternberg jsternberg deleted the js-6248-strings-in-select-panic branch April 7, 2016 16:33
@toddboom toddboom mentioned this pull request Apr 7, 2016
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic using incorrectly quoted "queries" field key
2 participants