Throw an error when time is compared to an invalid literal #6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-3932-error-on-invalid-timestamp
branch
from
b6d507b to
b862a6a
Compare
| } | ||
| } | ||
| return time.Time{} | ||
| return | ||
| } |
There was a problem hiding this comment.
Named returns seem confusing here. Why not just use returns at each case instead of assigning t and falling through?
There was a problem hiding this comment.
Personal preference. It was less typing and I thought it was more clear than repeating the same text everywhere. I can change it back.
jsternberg
force-pushed
the
js-3932-error-on-invalid-timestamp
branch
3 times, most recently
from
6288298 to
dccc85b
Compare
|
Needs a rebase, but LGTM. @benbjohnson |
|
👍 |
benbjohnson
force-pushed
the
js-3932-error-on-invalid-timestamp
branch
from
dccc85b to
c193bde
Compare
|
Rebased. Merging on 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bigger refactor of these functions is needed to support #3290, but
this will work for the more common case that someone uses double quotes
instead of single quotes when surrounding a time literal.
Fixes #3932.