IteratorStats #6073
Merged
IteratorStats #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2016
This commit adds an `IteratorStats` that holds aggregate iterator processing information. A method is also added to `Iterator` to return the stats: Stats() influxql.IteratorStats The remote iterators will also emit their stats in the point stream upon first connection, on a given interval, and then finally once the last point has been sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit adds an
IteratorStatsthat holds aggregate iterator processing information. A method is also added toIteratorto return the stats:Most
Iteratorimplementations simply call down to lower level iterators to retrieve stats and then useIteratorStats.Add()to merge them together.The remote iterators will also emit their stats in the point stream upon first connection, on a given interval, and then finally once the last point has been sent.
This functionality is required for properly implementing several of the query limits as well as providing insight into the internals of the system.
TODO
/cc @jsternberg @jwilder