Rewrite SHOW SERIES to SELECT #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Next emits the next point in the iterator. | ||
| func (itr *seriesIterator) Next() *influxql.FloatPoint { | ||
| for { |
There was a problem hiding this comment.
This loop will only iterate once.
There was a problem hiding this comment.
Fixed in ebf7cf1.
|
LGTM. Have you tested it on a local cluster @benbjohnson ? |
|
@e-dard Yes, I tested it in a local cluster and it works. |
benbjohnson
added a commit
that referenced
this pull request
Mar 8, 2016
Rewrite SHOW SERIES to SELECT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request rewrites
SHOW SERIESstatements intoSELECTstatements so they can be execute by the query engine.Fixes #5580