[0.10.2] Backport #5716 to 0.10.0 #5911
Conversation
These tests check that NewPoint and NewPointFromBytes return an error if: * arguments specify a point with no fields * arguments specify a point with a field that has an empty name These tests also check that Point.Fields() always returns, even in the presence of corrupt binary data read with NewPointFromBytes. These tests fail at this commit and are fixed by a subsequent commit. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
…fields Influx does not support fields with empty names or points with no fields. NewPoint is changed to validate that all field names are non-empty. AddField is removed because we now require that all fields are specified on construction. NewPointFromByte is changed to return an error if a unmarshaled binary point does not have any fields. newFieldsFromBinary is changed to prevent an infinite loop that can arise while attempting to parse corrupt binary point data. TestNewPointsWithBytesWithCorruptData is changed to reflect the change in the behaviour of NewPointFromByte. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
|
@jonseymour, but v0.10.2 has already been released. |
jonseymour
changed the title
|
@zstyblik sorry I interpreted [0.10.2] as being a statement about which version had the issue, rather than which version the fix will be delivered in. I have adjusted the title accordingly. |
jonseymour
changed the title
jonseymour
changed the title
|
@jonseymour, I see and you're right. I got confused by backport stuff V. the usual |
jonseymour
changed the title
|
@zstyblik The existence of this PR does not mean there will be a 0.10.3 - that's a call for inlfuxdata to make, not me. This PR contains a fix that could be trivially included in a hypothetical 0.10.3 if influxdata decides to build one. I opened the PR so that the fix is easily at hand, should they choose to use it. |
jonseymour
force-pushed
the
jss-5716-tolerate-empty-field-names-0.10.0
branch
from
aa873bc to
409f9a6
Compare
|
@jonseymour Could you rebase? |
jonseymour
force-pushed
the
jss-5716-tolerate-empty-field-names-0.10.0
branch
from
409f9a6 to
eb2f3c8
Compare
jonseymour
force-pushed
the
jss-5716-tolerate-empty-field-names-0.10.0
branch
from
eb2f3c8 to
7662c16
Compare
Signed-off-by: Jon Seymour <jon@wildducktheories.com>
jonseymour
force-pushed
the
jss-5716-tolerate-empty-field-names-0.10.0
branch
from
7662c16 to
ffa5f89
Compare
|
Repushed to deal with (spurious?) CI test failure. |
…d-names-0.10.0 [0.10.2] Backport #5716 to 0.10.0
This PR makes the #5716 fix available in 0.10.x.
These commits are actually the same commits that have already been merged into master - this PR will simply merge these commits into 0.10.0 and aim to eliminate a panic that occurs in the 0.10.x builds.