Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts all the uses of
time.Time
toint64
within the TSM engine. This was an idea initially presented in #5522, but didn't make sense to implement until query engine and other changes had completed.Since we mainly using timestamps as
UnixNano
values anyways, the overhead of using atime.Time
everywhere ends up creating a lot of garbage for GC to work though. This change should help with GC and larger queries that process a lot of points.A simple count query over 100M points improved from 53s to 38s with this change.
After: