Support mutable meta queries in a cluster #5753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-dard
changed the title
e-dard
force-pushed
the
er-meta-queries
branch
from
5ca27c5 to
b244af1
Compare
| panic("wrong connection type in MetaExecutor") | ||
| } | ||
| // Return connection to pool by "closing" it. | ||
| defer func(conn net.Conn) { conn.Close() }(conn) |
There was a problem hiding this comment.
Why is this wrapped in a function? Wouldn't this work the same:
defer conn.Close()
There was a problem hiding this comment.
Somebody must have been smoking crack. whistles innocently
|
Minor comments, otherwise lgtm 👍 |
e-dard
force-pushed
the
er-meta-queries
branch
from
e4d714f to
4424876
Compare
| return &MetaExecutor{ | ||
| timeout: DefaultWriteTimeout, | ||
| pool: newClientPool(), | ||
| maxConnections: 1000, |
There was a problem hiding this comment.
Is this max connections per node? If so, default is too high. We use 3 per-node for writes. Also, should be a constant like: https://github.com/influxdata/influxdb/blob/master/cluster/config.go#L21
e-dard
force-pushed
the
er-meta-queries
branch
from
4424876 to
cdfde23
Compare
dgnorton
force-pushed
the
er-meta-queries
branch
from
cdfde23 to
14668d1
Compare
The Meta Executor will make allow data nodes to execute queries remotely on each other, via RPC calls.
dgnorton
force-pushed
the
er-meta-queries
branch
from
f91d492 to
b306476
Compare
benbjohnson
added a commit
that referenced
this pull request
Feb 24, 2016
Support mutable meta queries in a cluster
|
🏆 |
This was referenced Feb 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5612, #5573 and #5518. Partially #2755
Adds support in a multi-node cluster for the following commands:
DROP DATABASE;DROP MEASUREMENT;DROP RETENTION POLICY;DROP SERIES.The approach is as follows. Queries that involve modifying data on Data Nodes will be handed off by the
QueryExecuterto theMetaExecutor. TheMetaExecutorwill then build appropriate messages and make RPC calls to all data nodes in the cluster.The node that received the query will apply any commands to its own
tsdb.Storelocally—they will not be sent over the network.Errors encountered from remotely executed commands will be collected by the
MetaExecutorand the first of these (if any) returned to the user.Assuming no errors were returned by any data nodes, the node executing the original query will then make any calls necessary to the Meta Store.
Detailed Flow for
DROP DATABASE:tsdb.Storetsdb.Store.DeleteDatabase.Errors propagate back from each node through RPC to the node that executed the statement on the cluster and that node returns failure if any node fails to execute.
TODO