added a button to generate permalink to queries entered in admin UI. #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vidhuran
force-pushed
the
bug4987-query-permalinks
branch
from
168b245 to
a147c40
Compare
|
Vidhuran
force-pushed
the
bug4987-query-permalinks
branch
from
a147c40 to
ee04650
Compare
|
@Vidhuran I like this idea, though I think it doesn't quite address what was asked for in #4987. I think that issue wanted a way to have permalinks open up the Admin UI directly. I still think this is a good addition, though I've got one small request. Can we change "Generate permalink" to "Generate Query URL" and the content inside the modal to "URL for the Query". If you can do that and rebase it, I'll get it merged for v0.13.0. Thanks! |
|
@toddboom Ah, Ok , I see the difference , i will make the changes that you had suggested for this PR and then make a new PR to fix the original problem. |
Vidhuran
force-pushed
the
bug4987-query-permalinks
branch
from
ee04650 to
fedb7bf
Compare
|
@Vidhuran Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4987