Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MetaServers from node.json #5695

Merged
merged 2 commits into from
Feb 16, 2016
Merged

Remove MetaServers from node.json #5695

merged 2 commits into from
Feb 16, 2016

Conversation

jwilder
Copy link
Contributor

@jwilder jwilder commented Feb 15, 2016

This removes the MetaServers property from node.json to eliminate one
of the four places those addresses are stored on disk. We always use
the values that come through the config (via file, env var or -join arg) to
simplify the server bootstrapping code.

Part of work to complete #5673

Meta HTTP commands are cluster level requests and were showing up in
the main log creating a lot of noise.  Switch them to use the ClusterTracing
config option which is disabled by default.
@jwilder
Copy link
Contributor Author

jwilder commented Feb 15, 2016

@corylanou

if err != nil {
if !os.IsNotExist(err) {
return nil, err
} else {
node = influxdb.NewNode(c.Meta.Dir, metaAddresses)
node = influxdb.NewNode(c.Meta.Dir)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like there is some future refactoring here yet. I'm not sure what purpose a node without a valid ID really serves. Just thinking out loud on this one. No action needed at this time.

@corylanou
Copy link
Contributor

Changelog then +1

This removes the MetaServers property from node.json to eliminate one
of the four places those addresses are stored on disk.  We always use
the values that come through the config (via file, env var or -join arg).
@e-dard
Copy link
Contributor

e-dard commented Feb 16, 2016

LGTM 👍

jwilder added a commit that referenced this pull request Feb 16, 2016
Remove MetaServers from node.json
@jwilder jwilder merged commit 9d478fa into master Feb 16, 2016
@jwilder jwilder deleted the jw-cluster branch February 16, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants