Add more stats for httpd, query executor #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| defer close(results) | ||
| q.statMap.Add(statQueriesActive, 1) | ||
| defer func(start time.Time) { | ||
| close(results) |
There was a problem hiding this comment.
Not sure why the close has moved into here? I think the following would be fine:
defer close(results)
defer func(start time.Time) { ... }(time.Now())
|
@mark-rushakoff Ben is currently moving the query executor to the |
mark-rushakoff
force-pushed
the
mr-expand-stats
branch
from
3a9d686 to
ddf028f
Compare
mark-rushakoff
force-pushed
the
mr-expand-stats
branch
from
ddf028f to
691a2a9
Compare
|
@e-dard Rebased and comment addressed. |
|
LGTM 👍 /cc @jwilder |
|
👍 |
|
@mark-rushakoff Could you add this to the changelog too? |
|
I'll update the changelog, wait for a green build, and merge. On Thu, Feb 18, 2016 at 1:44 PM, Jason Wilder notifications@github.com
|
mark-rushakoff
added a commit
that referenced
this pull request
Feb 18, 2016
Add more stats for httpd, query executor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four new stats in httpd:
queryReqDurationNs: time spent inside GET /querywriteReqDurationNs: time spent inside POST /writereqDurationNs: time spent handling any HTTP requestreqActive: number of currently active HTTP requestsTwo new stats in query executor:
queryDurationNs: time spent executing queriesqueriesActive: number of currently active/executing queries