parser: allow select from multiple series [#112] #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @peekeri, thanks for your contribution. We didn't implement this feature because it's achievable using regex |
Adjust parser to understand queries like 'SELECT * FROM series1, series2, ...'. It seems that selecting from multiple series was supported everywhere else, but parser just could not understand the syntax.
|
@jvshahid I saw from the issue #112 how the same can be achieved using regex, but as one of the nice features of InfluxDB query language is that it is easily understandable by non-programmers, I thought that maybe more convenient way to specify multiple series is something that would be appreciated by users that are not intimately familiar with regular expressions. I added two integration tests to data_test.go, please let me know if you think those are enough or should there be some more tests around this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust parser to understand 'SELECT * FROM series1, series2, ...' queries. It seems
that selecting from multiple series was supported everywhere else, but parser just
could not understand the syntax.
This should fix issue #112.