Enable golint on the tsdb/engine/wal
#5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabelev can you update the |
|
@e-dard: done. |
| @@ -243,6 +245,7 @@ func (l *Log) Open() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // DiskSize will returns the current size of a Log file. | |||
|
One minor nit. Otherwise +1. Will need a rebase as well. Thanks! |
gabelev
force-pushed
the
lint_engine_wal
branch
3 times, most recently
from
c207f44 to
a670ec4
Compare
|
@corylanou: made the small fix. rebased on master. |
|
@gabelev needs another rebase |
gabelev
force-pushed
the
lint_engine_wal
branch
from
a670ec4 to
0709887
Compare
gabelev
force-pushed
the
lint_engine_wal
branch
from
0709887 to
7d4217a
Compare
|
@e-dard: ok. rebased again. |
e-dard
added a commit
that referenced
this pull request
Feb 9, 2016
Enable `golint` on the tsdb/engine/wal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up tsdb/engine/wal.go and wal_test.go to enable golint per issue #4098.