Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite: prefer more specific template over default template when possible #5182

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

flisky
Copy link
Contributor

@flisky flisky commented Dec 21, 2015

No description provided.

@otoolep
Copy link
Contributor

otoolep commented Dec 21, 2015

@jwilder

@@ -602,6 +602,27 @@ func TestApplyTemplateSpecific(t *testing.T) {
}
}

// Test that most specific template is N/A
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that "the most specific template is not applicable? not applied? doesn't matter?" The comment is a little ambiguous.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahem, the first match should be applied in this case. However, it goes deeper to find a more specific one, but cannot find it. The original result will roll back to the global default template, not the first match.

@otoolep
Copy link
Contributor

otoolep commented Dec 21, 2015

@flisky -- have you signed the CLA?

@flisky
Copy link
Contributor Author

flisky commented Dec 22, 2015

Yes. I'm the guy who contributes #4807.

@otoolep
Copy link
Contributor

otoolep commented Dec 22, 2015

Ah yes, I remember that PR. Thanks.

On Monday, December 21, 2015, 尹吉峰 notifications@github.com wrote:

Yes. I'm the guy who contributes #4807
#4807.


Reply to this email directly or view it on GitHub
#5182 (comment).

@jwilder jwilder changed the title Graphite: fix an edge case in Parser.ApplyTemplate Graphite: prefer more specific template over default template when possible Feb 8, 2016
@jwilder jwilder added this to the 0.11.0 milestone Feb 8, 2016
jwilder added a commit that referenced this pull request Feb 8, 2016
Graphite: prefer more specific template over default template when possible
@jwilder jwilder merged commit 4002733 into influxdata:master Feb 8, 2016
@jwilder
Copy link
Contributor

jwilder commented Feb 8, 2016

Thanks @flisky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants