Fix the line protocol scanner to read field keys with quotes correctly #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think changelog needs to be updated. Otherwise, 👍 |
jsternberg
force-pushed
the
js-4076-line-protocol-parser-panics
branch
2 times, most recently
from
f68af13 to
2ff7ec6
Compare
|
Updated the changelog and I also decided to add a test from #4076 to verify that it correctly reported an error parsing one of the entires in that ticket. |
jsternberg
force-pushed
the
js-4076-line-protocol-parser-panics
branch
from
2ff7ec6 to
f7ce73e
Compare
Quotes are not supposed to be significant in field keys, but are
significant in field values. The code as it currently was would
consider quotes in a key to be significant, but the later parser that
would unmarshal the fields from the byte string did not consider those
quotes to be significant. This meant that the following string:
"a=1
The line protocol parser would see a mismatched quote instead of a valid
input to the line protocol. But more nefariously, the following string:
"a=1"=2
The line protocol parser would ignore the first equals since it is
located in the quotation marks and think this was a valid input. It
would then pass it on to the field parser who would panic and die when
it tried to parse `1"=2` as a number.
Fixes #4076.
jsternberg
force-pushed
the
js-4076-line-protocol-parser-panics
branch
from
f7ce73e to
4813d82
Compare
|
👍 |
1 similar comment
|
+1 |
jsternberg
added a commit
that referenced
this pull request
Dec 23, 2015
…anics Fix the line protocol scanner to read field keys with quotes correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quotes are not supposed to be significant in field keys, but are
significant in field values. The code as it currently was would
consider quotes in a key to be significant, but the later parser that
would unmarshal the fields from the byte string did not consider those
quotes to be significant. This meant that the following string:
The line protocol parser would see a mismatched quote instead of a valid
input to the line protocol. But more nefariously, the following string:
The line protocol parser would ignore the first equals since it is
located in the quotation marks and think this was a valid input. It
would then pass it on to the field parser who would panic and die when
it tried to parse
1"=2as a number.Fixes #4076.