Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop UDP point on bad parse and keep going #5029

Merged
merged 1 commit into from
Dec 8, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Dec 8, 2015

Before this change, if parsing a point failed, the goroutine servicing the UDP input would exit, resulting in the UDP input blocking. Instead, drop the point and continue.

Fixes issue #4992.

@otoolep otoolep force-pushed the dont_quit_udp_on_bad_parse branch from de51c8b to b0a4ddc Compare December 8, 2015 03:41
@otoolep
Copy link
Contributor Author

otoolep commented Dec 8, 2015

@corylanou

@otoolep
Copy link
Contributor Author

otoolep commented Dec 8, 2015

Or @jwilder or @dgnorton

@otoolep
Copy link
Contributor Author

otoolep commented Dec 8, 2015

@sparrc

@pauldix
Copy link
Member

pauldix commented Dec 8, 2015

+1 can you pull into 0.9.6?

@otoolep
Copy link
Contributor Author

otoolep commented Dec 8, 2015

OK @pauldix

@otoolep otoolep force-pushed the dont_quit_udp_on_bad_parse branch from b0a4ddc to a5cb913 Compare December 8, 2015 03:48
otoolep added a commit that referenced this pull request Dec 8, 2015
Drop UDP point on bad parse and keep going
@otoolep otoolep merged commit ff4c30b into master Dec 8, 2015
@otoolep otoolep deleted the dont_quit_udp_on_bad_parse branch December 8, 2015 03:48
@otoolep
Copy link
Contributor Author

otoolep commented Dec 8, 2015

Cherry-picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants