Validate previous value in derivative calls #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
nc-issue#4666
branch
from
901a06c to
daaaacb
Compare
nathanielc
changed the title
|
👍 |
nathanielc
force-pushed
the
nc-issue#4666
branch
from
daaaacb to
bd6961a
Compare
nathanielc
pushed a commit
that referenced
this pull request
Dec 4, 2015
Validate previous value in derivative calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4666
Somehow its possible that a single value in the list of values is invalid which causes a panic.
Added correct validation code and tests.
@jwilder Do you want to take a look at this?