Fix flush deadlock #4913
Merged
Fix flush deadlock #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a deadlock that occurs during b1 flushes. It's caused by taking locks in a different order. In the flush, b1 locks the engine and then bolt. However, in the query cursor, a lock is obtained on bolt first (via `DB.Begin()`) and then the engine is locked while reading from the engine's cache.
benbjohnson
force-pushed
the
b1-deadlock
branch
from
8aa0b10 to
41459cf
Compare
|
Awesome catch! +1 |
|
+1 nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit fixes a deadlock that occurs during b1 flushes. It's caused by taking locks in a different order. In the flush, b1 locks the engine and then bolt. However, in the query cursor, a lock is obtained on bolt first (via
DB.Begin()) and then the engine is locked while reading from the engine's cache./cc @corylanou @pauldix @beckettsean