Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxQL: FormatDuration uses "u" for microsecond units #4891

Merged
merged 1 commit into from
Dec 4, 2015

Conversation

mark-rushakoff
Copy link
Contributor

Previously, it was formatting microsecond durations without any units.
Currently, all durations must have units explicitly specified.

@dgnorton
Copy link
Contributor

+1

@mark-rushakoff mark-rushakoff force-pushed the duration-must-have-units branch 2 times, most recently from 4620943 to d61df55 Compare November 24, 2015 20:27
@mark-rushakoff
Copy link
Contributor Author

Rebased due to merge conflict in CHANGELOG, but the code didn't change. Still waiting on a second +1 before merging.

Previously, it was formatting microsecond durations without any units.
Currently, all durations must have units explicitly specified.
@mark-rushakoff mark-rushakoff force-pushed the duration-must-have-units branch from d61df55 to da8c560 Compare December 2, 2015 17:01
@otoolep
Copy link
Contributor

otoolep commented Dec 4, 2015

+1

mark-rushakoff added a commit that referenced this pull request Dec 4, 2015
InfluxQL: FormatDuration uses "u" for microsecond units
@mark-rushakoff mark-rushakoff merged commit d2f8a10 into master Dec 4, 2015
@mark-rushakoff mark-rushakoff deleted the duration-must-have-units branch December 4, 2015 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants