-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added framework for cluster integration testing #4848
Conversation
Keep it up! |
1335a82
to
9dd01a9
Compare
bb33941
to
edf8e31
Compare
Added framework for cluster integration testing
Looks great so far. One thing I'd like is to have every query test represented at the integration level, which can be run on a single server, or different cluster configurations. You mentioned that's still in process, but it would be nice to be able to define the test and output in one place and run in various configs. |
@pauldix I'm not sure if I understand, but to give you an idea of how it currently works: The
Also, we could easily make the cluster tests cycle through and run the tests in single, 2 node, 3 node, 4 node, 5 node, 6 node, and 7 node configuration very easily. Currently, we have coverage in a single node and 5 node cluster. Based on that, what are you proposing we do add? |
This PR adds the framework for cluster integration testing. It also fixes the following bugs:
-parallel
argument passed into our test suite. Disabling that has no noticeable affect on how long it takes to run tests, but they no longer fail intermittently.RemoteAddr
. This is only necessary for testing due to spinning up on random system ports likelocalhost:0
DatabaseNotFound
could return different error text depending on where in the code branch it was determined that there was no database. This caused intermittent test results.