Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #4816 some aggregate function work incorrectly in cluster mode #4817

Merged
merged 3 commits into from
Nov 21, 2015

Conversation

mengjinglei
Copy link
Contributor

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

@otoolep
Copy link
Contributor

otoolep commented Nov 17, 2015

Is there any way to unit test this?

@mengjinglei
Copy link
Contributor Author

I noticed that there is no unit test case for InitializeUnmarshaller function in tsdb/functions_test.go, but I'd like to have a try.

@mengjinglei
Copy link
Contributor Author

Unmarshaller unmarshal bytes receive from remote node to interface that reducer can use, for min and max functions, the input interface of reducer is expect to be minMaxMapOut, but there is no specific unmarshaller for min and max functions, so the bytes are unmarshal by default unmarshaller whose output can not be recognize by the reducer

@mengjinglei mengjinglei changed the title fix issue #4816 fix issue #4816 some aggregate function work incorrectly in cluster mode Nov 18, 2015
@mengjinglei
Copy link
Contributor Author

@otoolep

@otoolep
Copy link
Contributor

otoolep commented Nov 19, 2015

+1

@dgnorton -- can you please also review?

@otoolep
Copy link
Contributor

otoolep commented Nov 19, 2015

CLA confirmed signed.

@dgnorton
Copy link
Contributor

+1

@mengjinglei
Copy link
Contributor Author

@otoolep

@otoolep
Copy link
Contributor

otoolep commented Nov 21, 2015

Thanks @mengjinglei

otoolep added a commit that referenced this pull request Nov 21, 2015
fix issue #4816 some aggregate function work incorrectly in cluster mode
@otoolep otoolep merged commit 3ae624e into influxdata:master Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants