WHERE fields must be decoded during aggregates #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Real fix for #4701 |
otoolep
force-pushed
the
multi_field_agg
branch
from
e9a12cb to
7d0fa41
Compare
|
Will cherry-pick this to 0.9.5 when merged to master. |
This change ensures that if there are any fields in the WHERE clause of an aggregate that are different from the fields in the SELECT clause, that the cursors also decode those fields. Otherwise WHERE clauses of the form 'SELECT f(w) FROM x WHERE y=z' will return incorrect results Fixes issue #4701.
otoolep
force-pushed
the
multi_field_agg
branch
from
7d0fa41 to
912684b
Compare
| @@ -649,7 +649,7 @@ func (m *AggregateMapper) openMeasurement(mm *Measurement) error { | |||
| } | |||
|
|
|||
| for i, key := range t.SeriesKeys { | |||
| fields := slices.Union(selectFields, m.fieldNames, false) | |||
| fields := slices.Union(slices.Union(selectFields, m.fieldNames, false), m.whereFields, false) | |||
There was a problem hiding this comment.
nit: This looks a little ugly. Future refactoring perhaps?
There was a problem hiding this comment.
I actually think it looks good! What could be clearer? :-)
|
Fix makes sense. +1 |
|
👍 |
otoolep
added a commit
that referenced
this pull request
Nov 14, 2015
WHERE fields must be decoded during aggregates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that if there are any fields in the WHERE clause of an aggregate that are different from the fields in the SELECT clause, that the cursors also decode those fields. Otherwise WHERE clauses of the form
SELECT f(w) FROM x WHERE y=zwill return incorrect results