Changed help command output from inside the cli

[aneshas]

Changed help command output from inside the cli to
match the info provided by the influx --help output

Added history command as suggested by @gunnaraasen

Minor edits as proposed by @beckettsean

Removed command names duplication and

Closes #4722

• CHANGELOG.md updated
• Rebased/mergable
• Tests pass
• Sign CLA (if not already signed)

Signed-off-by: Anes Hasicic anes.hasicic@gmail.com

[otoolep]

Thanks @aneshas - have you signed the CLA?

[aneshas]

@otoolep Yes I have

[otoolep]

Thanks, CLA confirmed signed.

[gunnaraasen]

This is a good cleanup but I don't think it addresses all of #4722 since there are still some recently added shell commands like history that are not listed in the shell help text.

[aneshas]

@gunnaraasen You are right

[aneshas]

There is also gopher command

[otoolep]

That command is not meant for documentation.

[aneshas]

So there is only history command left, what description do I put?

[otoolep]

"Display command history" works for me, no need to be fancy.

[otoolep]

The build failure is nothing to do with your change, it's something else.

[beckettsean]

I think we need to leave "toggle" in the description. Once pretty print is enabled, sending pretty again disables it.

"Pretty toggles pretty print for the json format "

[beckettsean]

minor edits

[aneshas]

@beckettsean Should be done :)

[otoolep]

I'm not sure I like this format of continually repeating the command in the explanation -- it seems overly verbose. I preferred the older format.

@beckettsean

[beckettsean]

@otoolep I'm indifferent to repeating the command. I think the canonical style is to omit the command in the -help output, but I don't think it's poor form to do it this way. It's verbose, but clear.

I would lean towards removing the duplication of the command but I wouldn't hold the PR to wait for it.

[otoolep]

That's fine, I'll defer to you @beckettsean

[otoolep]

OK, +1 from me.

+1 from you @beckettsean ?

[beckettsean]

@gunnaraasen care to weigh in?

[gunnaraasen]

I'm all for reducing verbosity but this looks good for now.

[aneshas]

@beckettsean Care to elaborate, you really got me here:
this isn't a valid query, it requires with key = <tag_key>.

Let's remove it in favor of show field keys, which is valid and mirrors show tag keys.

So I need to put back show tag keys in and put show field keys instead of show tag values ?

@otoolep I will remove duplication of commands also

[aneshas]

ok, done @otoolep @beckettsean

[beckettsean]

Looks good to me. Confirming the CLA has been signed.

@otoolep I can't imagine the CI failure is related, but can you confirm before I merge?

[otoolep]

Yeah, we can ignore the failure.

[otoolep]

@aneshas -- please send me an email so we can send you a t-shirt!

[aneshas]

Tnx :D @otoolep anes.hasicic@gmail.com is my e-mail