Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display "deleted" shards in SHOW SHARDS output #4725

Merged
merged 3 commits into from
Nov 10, 2015
Merged

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Nov 10, 2015

If a shard's "owning" shard group has been marked as deleted, the shard is, or soon will be, deleted. So don't list shards that are effectively deleted.

The constant for minimum retention policy was also duplicated in the code, and this was a mistake. This PR also fixes that, setting the constant in one place. It also enhances logging, as requested by @beckettsean

Fixes issue #4709.

@otoolep otoolep changed the title Don't displayed "deleted Don't displayed "deleted" SHARDS Nov 10, 2015
@otoolep otoolep changed the title Don't displayed "deleted" SHARDS Don't display "deleted" SHARDS Nov 10, 2015
@otoolep
Copy link
Contributor Author

otoolep commented Nov 10, 2015

@corylanou @benbjohnson

@otoolep otoolep changed the title Don't display "deleted" SHARDS Don't display "deleted" in SHOW SHARDS output Nov 10, 2015
@otoolep otoolep changed the title Don't display "deleted" in SHOW SHARDS output Don't display "deleted" shards in SHOW SHARDS output Nov 10, 2015
@corylanou
Copy link
Contributor

+1

otoolep added a commit that referenced this pull request Nov 10, 2015
Don't display "deleted" shards in SHOW SHARDS output
@otoolep otoolep merged commit 8022c28 into master Nov 10, 2015
@otoolep otoolep deleted the deleted_sgs branch November 10, 2015 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants