export interfaceValues since it is returned from DisticntReduce #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine with me. I feel @benbjohnson should be informed since he's working in this area (I believe). |
|
Works for me. |
nathanielc
pushed a commit
that referenced
this pull request
Nov 10, 2015
export interfaceValues since it is returned from DisticntReduce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to convert the values returned from Reduce function into something meaning full on my end. Since
interfaceValueswas not exported I could not type assert it and then iterate over its values. Exporting it allows for this behavior. Exporting seemed better than iterating over it after sorting in order to return a[]interface{}.