Fix restore panic issue #4671 #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unpacking the meta, the Store `Addr` is built against the hostname and the `bind-address` port. We can use this resolved address for the `RemoteAddr` as well since according to the clustering docs the `hostname must be resolved by all members in the cluster`
|
cc @benbjohnson Thanks @simcap -- have you signed the CLA? |
|
👍 |
|
https://influxdb.com/community/cla.html @simcap -- if you sign the link above we will merge. |
|
I signed it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unpacking the meta, the Store
Addris built against the hostname and thebind-addressport.We can use this resolved address for the
RemoteAddras well since according to the clustering docs thehostname must be resolved by all members in the cluster