Exit when invalid engine is selected

[otoolep]

Fix #4585, related to #4583

[otoolep]

It is not possible to exit short of a panic, but this change makes it very clear in the logs.

[write] 2015/10/27 11:56:14 write failed for shard 1 on node 1: new engine: engine xxx does not exist
[monitor] 2015/10/27 11:56:14 failed to store statistics: write failed: new engine: engine xxx does not exist
[write] 2015/10/27 11:56:24 write failed for shard 1 on node 1: new engine: engine xxx does not exist
[monitor] 2015/10/27 11:56:24 failed to store statistics: write failed: new engine: engine xxx does not exist

[otoolep]

@jwilder @beckettsean

[beckettsean]

works for me

[jwilder]

Could we validate this in the config? i.e.: https://github.com/influxdb/influxdb/blob/master/cmd/influxd/run/command.go#L104

[otoolep]

Yeah, that might be better. Let me try that.

On Tue, Oct 27, 2015 at 12:19 PM, Jason Wilder notifications@github.com
wrote:

Could we validate this in the config? i.e.:
https://github.com/influxdb/influxdb/blob/master/cmd/influxd/run/command.go#L104

—
Reply to this email directly or view it on GitHub
#4586 (comment).

[otoolep]

OK, updated as per @jwilder . Program now exits, which is better.

$ ./influxd -config ~/Dropbox/influxdb/config.graphite.toml 

 8888888           .d888 888                   8888888b.  888888b.
   888            d88P"  888                   888  "Y88b 888  "88b
   888            888    888                   888    888 888  .88P
   888   88888b.  888888 888 888  888 888  888 888    888 8888888K.
   888   888 "88b 888    888 888  888  Y8bd8P' 888    888 888  "Y88b
   888   888  888 888    888 888  888   X88K   888    888 888    888
   888   888  888 888    888 Y88b 888 .d8""8b. 888  .d88P 888   d88P
 8888888 888  888 888    888  "Y88888 888  888 8888888P"  8888888P"

2015/10/27 17:10:46 InfluxDB starting, version 0.9, branch unknown, commit unknown, built unknown
2015/10/27 17:10:46 Go version go1.5.1, GOMAXPROCS set to 8
2015/10/27 17:10:46 Using configuration at: /home/philip/Dropbox/influxdb/config.graphite.toml
run: unrecognized engine xxx. To generate a valid configuration file run `influxd config > influxdb.generated.conf`.

[otoolep]

This pattern, of adding Validate to individual config types, exists elsewhere in the code.

[jwilder]

👍