Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop raft node #4547

Merged
merged 9 commits into from
Oct 26, 2015
Merged

Drop raft node #4547

merged 9 commits into from
Oct 26, 2015

Conversation

corylanou
Copy link
Contributor

Currently, if you drop a raft node (even the leader), to bring another raft node to the cluster, you must launch a NEW node. Shutting down an existing node and bringing it back up does not make it a raft by default. This will be fixed in a future PR.

@otoolep
Copy link
Contributor

otoolep commented Oct 22, 2015

What happens if the node being dropped is in communication with the cluster?

@otoolep
Copy link
Contributor

otoolep commented Oct 22, 2015

Working with @corylanou here, seeing some funnies on non-dropped nodes after dropping the node.

@@ -519,7 +535,9 @@ func (s *Store) createLocalNode() error {
}

// Set ID locally.
s.mu.Lock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here, outlining why this locking is done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was detected as a race by our race detector. Likely only due to test code and would not be a race condition in production, but better safe than sorry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant a comment in the code. :-)

@otoolep
Copy link
Contributor

otoolep commented Oct 22, 2015

After more system debug, looks like a false alarm. @corylanou doing more system-level testing on systems with a dropped node, even if the node was up and running when dropped.

@@ -21,6 +21,7 @@
- [#4375](https://github.com/influxdb/influxdb/pull/4375): Add Subscriptions so data can be 'forked' out of InfluxDB to another third party.
- [#4506](https://github.com/influxdb/influxdb/pull/4506): Register with Enterprise service and upload stats, if token is available.
- [#4501](https://github.com/influxdb/influxdb/pull/4501): Allow filtering SHOW MEASUREMENTS by regex.
- [#4547](https://github.com/influxdb/influxdb/pull/4547): Drop raft node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so the guys reading the CHANGELOG know what this about is about can you rephrase it as something like:

DROP SERVER for all node types (or something).

@otoolep
Copy link
Contributor

otoolep commented Oct 23, 2015

Some feedback, but this generally all makes sense to me. +1

corylanou added a commit that referenced this pull request Oct 26, 2015
@corylanou corylanou merged commit fdcc811 into master Oct 26, 2015
@corylanou corylanou deleted the drop-raft-node branch October 26, 2015 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants