Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering SHOW MEASUREMENTS by regex #4501

Merged
merged 4 commits into from
Oct 19, 2015
Merged

Allow filtering SHOW MEASUREMENTS by regex #4501

merged 4 commits into from
Oct 19, 2015

Conversation

dgnorton
Copy link
Contributor

This change allows the results of SHOW MEASUREMENTS to be filtered by regular expression. For example, the following query would return all measurements that begin with cpu:

SHOW MEASUREMENTS WITH MEASUREMENT =~ /cpu.*/

},
&Query{
name: `show measurements using WITH and regex`,
command: "SHOW MEASUREMENTS WITH MEASUREMENT =~ /[cg]pu/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a test where the regex shouldn't match anything?

@otoolep
Copy link
Contributor

otoolep commented Oct 19, 2015

Seems fine, though I think it could do with one more test.

+1 on adding that extra test (unless I am missing something).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants