Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually check connection errors #4465

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Actually check connection errors #4465

merged 1 commit into from
Oct 15, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Oct 15, 2015

Fix issue #4463

@otoolep otoolep force-pushed the check_connect_error branch from 21786b4 to 6252f17 Compare October 15, 2015 22:03
@otoolep
Copy link
Contributor Author

otoolep commented Oct 15, 2015

With actual error checking, a helpful response is returned:

$ influx                                                                                                                                          
Failed to connect to http://localhost:8086
Please check your connection settings and ensure 'influxd' is running.

@otoolep
Copy link
Contributor Author

otoolep commented Oct 15, 2015

@beckettsean @corylanou

@beckettsean
Copy link
Contributor

Nice catch, much improved!

otoolep
otoolep reviewed Oct 15, 2015
View reviewed changes
cmd/influx/main.go
@@ -158,7 +158,10 @@ Examples:
}

if err := c.connect(""); err != nil {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually do something if an error is returned, don't just carry on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what??? lol, crazy! I think code reviews failed us the last time. Nice catch.

@otoolep otoolep force-pushed the check_connect_error branch from 6252f17 to 81390db Compare October 15, 2015 22:07
@jwilder
Copy link
Contributor

jwilder commented Oct 15, 2015

👍

2 similar comments
@gunnaraasen
Copy link
Member

👍

@corylanou
Copy link
Contributor

+1

otoolep added a commit that referenced this pull request Oct 15, 2015
@otoolep
Merge pull request #4465 from influxdb/check_connect_error
8a08f34 
Actually check connection errors
@otoolep otoolep merged commit 8a08f34 into master Oct 15, 2015
@otoolep otoolep deleted the check_connect_error branch October 15, 2015 22:17
@otoolep otoolep mentioned this pull request Oct 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@otoolep @beckettsean @jwilder @gunnaraasen @corylanou