Issue #4446: Fixing logrotate config file.

[linsomniac]

This issue switches from "cp" to "install" for the logrotate file,
with the option to specify the mode. Also uses the name "influxdb"
instead of "influxd".

[beckettsean]

@rossmcdonald

[otoolep]

If we are going to do this, we need to tweak the post-install script to remove any existing file named influxd.conf.

Running logrotate -d I don't see any indication that the existing permissions are a problem, but I have no objection to change them as it just removes the group write bit.

[linsomniac]

Sample session on Ubuntu 14.04 system:

root@graphs:/etc/logrotate.d# ls -l influxd 
-rw-rw-r-- 1 root root 113 Sep 14 16:12 influxd
root@graphs:/etc/logrotate.d# logrotate -d -f /etc/logrotate.conf 2>&1 | grep influx
Ignoring influxd because of bad file mode.
root@graphs:/etc/logrotate.d# chmod 644 influxd 
root@graphs:/etc/logrotate.d# logrotate -d -f /etc/logrotate.conf 2>&1 | grep influx
reading config file influxd
rotating pattern: /var/log/influxdb/influxd.log  forced from command line (7 rotations)
considering log /var/log/influxdb/influxd.log
rotating log /var/log/influxdb/influxd.log, log->rotateCount is 7
destination /var/log/influxdb/influxd.log-20151015.gz already exists, skipping rotation
root@graphs:/etc/logrotate.d# dpkg -l logrotate
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-==================================
ii  logrotate      3.8.7-1ubunt amd64        Log rotation utility

[otoolep]

I think this is good to merge, but I need to add more changes to this to remove any pre-existing rotate file.

[otoolep]

@linsomniac -- have you signed the CLA?

[linsomniac]

Shouldn't be a problem, I need to have someone review it first. Probably can sign it tomorrow.

[linsomniac]

Signed both by me and the company CTO.

[otoolep]

Thanks @linsomniac