Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject line protocol that terminates with '-' #4296

Merged
merged 1 commit into from
Oct 2, 2015
Merged

Reject line protocol that terminates with '-' #4296

merged 1 commit into from
Oct 2, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Oct 2, 2015

Fixes issue #4272.

@otoolep
Copy link
Contributor Author

otoolep commented Oct 2, 2015

@jwilder

@@ -560,6 +560,10 @@ func scanNumber(buf []byte, i int) (int, error) {
// Is negative number?
if i < len(buf) && buf[i] == '-' {
i += 1
// There must be more characters now.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add that this is checking for a field value of just '-'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@jwilder
Copy link
Contributor

jwilder commented Oct 2, 2015

Small comment suggestion 👍 though

otoolep added a commit that referenced this pull request Oct 2, 2015
Reject line protocol that terminates with '-'
@otoolep otoolep merged commit 3085fbc into master Oct 2, 2015
@otoolep otoolep deleted the issue_4272 branch October 2, 2015 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants