Fix cluster-level error marshalling #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
error_marshalling
branch
from
3d29229 to
591e33b
Compare
|
👍 |
otoolep
added a commit
that referenced
this pull request
Sep 30, 2015
Fix cluster-level error marshalling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects use of the error-message lookup table, so that errors that are marshalled just as strings across the cluster are correctly recognised on the receiving nodes. This allows the higher-level code to continue to use error types such as
ErrRetentionPolicyNotFoundThis fix required that certain error prefixes be removed from error handling, and that errors are passed through cleanly.
Fixes #4267