Figure out the InfluxDB version from /ping and show it on the admin page

[alexiri]

I noticed the InfluxDB version at the bottom of the admin page is hardcoded (currently to 0.9.3) and it hasn't been updated to 0.9.4. #4117 updates the version, but here's a patch to dynamically get the version from /ping instead.

[corylanou]

Nice. +1. /cc @toddboom

[toddboom]

I like this. I'm wondering if it makes sense to have both the client version (possibly still hardcoded) and the server version (pulled from the ping), just to help with debugging in the future. What do you think?

[alexiri]

I'm not sure I see the usefulness of that, I wasn't aware that the admin page had a "client" version different from the server. I guess it could make sense if you were connecting from one server's admin page to a different server. Still, keeping a hardcoded version number that must be updated with each release negates a bit the spirit of this change, which was to hardcode fewer things. :)

By the way, the version number could also be extracted from the "SHOW DATABASES" query which runs at startup anyway.

[otoolep]

SHOW DIAGNOSTICS will return full build information.

On Thursday, September 17, 2015, Alex Iribarren notifications@github.com
wrote:

I'm not sure I see the usefulness of that, I wasn't aware that the admin
page had a "client" version different from the server. I guess it could
make sense if you were connecting from one server's admin page to a
different server. Still, keeping a hardcoded version number that must be
updated with each release negates a bit the spirit of this change, which
was to hardcode fewer things. :)

By the way, the version number could also be extracted from the "SHOW
DATABASES" query which runs at startup anyway.

—
Reply to this email directly or view it on GitHub
#4125 (comment).

[alexiri]

Yes, I meant that calling "/query?q=SHOW+DATABASES" would also return the header with the version that I'm using in my patch.

[otoolep]

Yeah, that query will work. The nice thing about SHOW DIAGNOSTICS is that the commit and branch of the build will also be returned. That richer information may be useful.

[simi]

It will be great to add statik compilation into build steps and hardcode admin version in the build process. I'll try to inspect this.

[corylanou]

@toddboom can you review this. I'm fine with it if we rebase. Thoughts?

[simi]

I think id can be used here instead of class to match another tag lookups in javascript.

[toddboom]

@corylanou agreed. i added one change to split out the version numbers, rebased, and merged. thanks @alexiri!