Added precision support in cmd client #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @sbouchex -- have you signed the CLA? |
|
fixes #2675 |
|
@otoolep, yep, already signed. |
|
+1 from me. @corylanou ? |
|
Confirmed CLA signed. |
| @@ -30,6 +30,8 @@ var ( | |||
| const ( | |||
| // defaultFormat is the default format of the results when issuing queries | |||
| defaultFormat = "column" | |||
|
|
|||
| defaultPrecision = "" | |||
There was a problem hiding this comment.
Actually, the default precision is actually nanos, right? So can you set this correctly?
There was a problem hiding this comment.
+1 for defaulting to nano
|
1 question what the default should actually be. |
|
OK, fine, I can change to nano and I will add an option to return 'RFC3339' since it can be understood more easily. So to confirm:
Client library part is not changed |
|
Works for me. @corylanou ? |
|
+1 |
otoolep
added a commit
that referenced
this pull request
Sep 14, 2015
Added precision support in cmd client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added precision support in cmd client in order to have the ability to export timestamp in any support format (secondes, hour...)