Add pending control to batcher #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
buffered_batcher
branch
2 times, most recently
from
658eba1 to
6035acd
Compare
| // NewPointBatcher returns a new PointBatcher. | ||
| func NewPointBatcher(sz int, d time.Duration) *PointBatcher { | ||
| // NewPointBatcher returns a new PointBatcher. sz is the batching size, | ||
| // bf is the maximum number of batches that may be pending. d is the time |
There was a problem hiding this comment.
Ha, I used to call it bf in the code, but forgot to update the comment -- thanks.
|
Small comment issue but 👍 |
With this change, the generic batcher used by many inputs can now be buffered. Testing shows that this performance of the Graphite input by 10-100%, with the biggest improvements at lower numbers of connections.
otoolep
force-pushed
the
buffered_batcher
branch
from
6035acd to
24aca56
Compare
|
Hello, Many thanks for this change and your continual improvements - every new version generally keeps getting better 👍 Have been running this version in our testing environment and it looks much, much better write performance to graphite plugin wise. We have not seen a client write failure since the upgrade and CPU usage of InfluxDB has dropped a bit on average as well. There is only one connection in to the influxdb graphite plugin. Client logs: [2015-09-10 10:46:46] failed to write() to 127.0.0.1:2013: Connection reset by peer
[2015-09-10 10:46:58] server 127.0.0.1:2013: OK
[2015-09-10 10:50:36] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 10:50:36] server 127.0.0.1:2013: OK
[2015-09-10 10:50:38] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 10:50:38] server 127.0.0.1:2013: OK
[2015-09-10 11:12:36] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:12:36] server 127.0.0.1:2013: OK
[2015-09-10 11:13:38] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:13:38] server 127.0.0.1:2013: OK
[2015-09-10 11:17:36] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:17:36] server 127.0.0.1:2013: OK
[2015-09-10 11:17:38] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:17:38] server 127.0.0.1:2013: OK
[2015-09-10 11:33:36] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:33:36] server 127.0.0.1:2013: OK
[2015-09-10 11:34:36] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:34:36] server 127.0.0.1:2013: OK
[2015-09-10 11:36:36] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:36:36] server 127.0.0.1:2013: OK
[2015-09-10 11:39:35] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:39:36] server 127.0.0.1:2013: OK
[2015-09-10 11:40:36] failed to write() to 127.0.0.1:2013: uncomplete write
[2015-09-10 11:40:36] server 127.0.0.1:2013: OK
[2015-09-10 12:16:20] failed to write() to 127.0.0.1:2013: Connection reset by peer
[2015-09-10 12:17:28] server 127.0.0.1:2013: OK12:16:20 was when the DB was upgraded - no write errors since then. |
|
Great, thanks for the feedkback @pkittenis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the generic batcher used by many inputs can now be buffered. Testing shows that this improves performance of the Graphite input by 10-100%, with the biggest improvements at lower numbers of connections. Internal testing showed that this configuration -- a batcher per service, as opposed to per connection -- gave the best throughput and stable behaviour.
This patch also sets defaults for UDP input batching, which were not being set before.