Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close nil channel in TSDB #4035

Merged
merged 1 commit into from
Sep 8, 2015
Merged

Don't close nil channel in TSDB #4035

merged 1 commit into from
Sep 8, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Sep 8, 2015

Obviously a TSDB store may be closed before it's opened.

@otoolep
Don't close nil channel
255fb33 
Obviously a TSDB store may be closed before it's opened.
@otoolep
Copy link
Contributor Author

otoolep commented Sep 8, 2015

@jwilder

@otoolep
Copy link
Contributor Author

otoolep commented Sep 8, 2015

Somehow master is now showing that this could happen. Not sure if it's related to the ordering change @jwilder made in dabb016

@otoolep
Copy link
Contributor Author

otoolep commented Sep 8, 2015

https://circle-artifacts.com/gh/influxdb/influxdb/5651/artifacts/2/tmp/circle-artifacts.11dnhWk/test_logs_race.txt

--- FAIL: TestServer_Query_ShowMeasurements (0.64s)
panic: close of nil channel [recovered]
    panic: close of nil channel

goroutine 137 [running]:
testing.tRunner.func1(0xc82009b680)
    /tmp/workdir/go/src/testing/testing.go:450 +0x1f5
github.com/influxdb/influxdb/tsdb.(*Store).Close(0xc8200b0380, 0x0, 0x0)
    /home/ubuntu/influxdb-build/src/github.com/influxdb/influxdb/tsdb/store

@jwilder
Copy link
Contributor

jwilder commented Sep 8, 2015

👍

otoolep added a commit that referenced this pull request Sep 8, 2015
@otoolep
Merge pull request #4035 from influxdb/nil_chan
2dd621d 
Don't close nil channel in TSDB
@otoolep otoolep merged commit 2dd621d into master Sep 8, 2015
@otoolep otoolep deleted the nil_chan branch September 8, 2015 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otoolep @jwilder