Copier service #3975
Merged
Copier service #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
force-pushed
the
copy-shard
branch
from
178655e to
67a006d
Compare
|
Seems reasonable, nothing jumped out at me. +1 |
| // readResponse reads and unmarshals a Response from r. | ||
| func (c *Client) readResponse(r io.Reader) (*internal.Response, error) { | ||
| // Read response length. | ||
| var n uint32 |
There was a problem hiding this comment.
Should this be a uint64? Shards files can be larger than 4gb, right?
There was a problem hiding this comment.
That's just for the response header. The shard writes out its data size as a uint64.
There was a problem hiding this comment.
Oh. Maybe this is just the length of the protobuf response.
This commit adds the copier service which allows one server to copy shards from another server. This will be used for moving shards in the cluster.
benbjohnson
force-pushed
the
copy-shard
branch
from
67a006d to
deff06f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds the copier service which allows one server to copy shards from another server. This will be used for moving shards in the cluster.
Additional Notes
<uint64(length)><bytes...>copier.Clientprovided for easier integration.io.WriterToadded to thetsdb.Engineinterface and tob1&bz1implementations.