-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bz1 size benchmarks #3744
Add bz1 size benchmarks #3744
Conversation
return nil | ||
}) | ||
return stats, err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this to retrieve per-series page allocation stats.
Can you go bigger than 32k and see what it does? Curious what it looks like all the way up to like 256k or something. |
Oh, also, will the leaf utilization have a big impact on the size of the overall BoltDB? |
This commit add benchmarks to show the size difference between different block sizes.
@pauldix New results:
The leaf utilization is the most important because there's a lot more leaf pages than branch pages. It gives a good indication of overall file utilization. However, the bytes/pt is really the more important metric. There's a point of diminishing returns with large blocks because it's harder for Bolt to reallocate contiguous pages and you can get fragmentation. I think 32KB or 64KB is probably a good block size. |
Sure, 64k sounds good |
Overview
This pull request add benchmarks to show the size difference between different block sizes.
Results
/cc @pauldix