Logging enhancements and single-node rename #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +57,9 @@ func NewService(c Config) *Service { | |||
|
|
|||
| // Open starts the service. | |||
| func (s *Service) Open() error { | |||
|
|
|||
| s.Logger.Printf("Starting collected service") | |||
|
+1, just very minor stuff. |
| @@ -53,6 +53,8 @@ func NewService(c Config) *Service { | |||
|
|
|||
| // Open opens the network listener and begins serving requests. | |||
| func (s *Service) Open() error { | |||
|
|
|||
| s.Logger.Println("Staring cluster service") | |||
Renaming a host that is a raft peer member is pretty difficult but we can special case single-node renames since we know all the member in the cluster and we can update the peer store directly on all nodes (just one). Fixes #3632
Make is much easier to determine when a cluster is in a healthly state as well as who the current leader is.
* Capitalize first letter of message * Log all services staring consistently * Remove some extraneous log statements in meta.Store * Log data dirs for meta, data and hinted handoff
jwilder
added a commit
that referenced
this pull request
Aug 13, 2015
Logging enhancements and single-node rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it more seamless to rename a single-node cluster. Renaming a raft peer in a multiple node cluster still requires operator intervention.
This also cleans up the logging to add more consistency to what and how things are logged. Specifically: