Cap auto-created retention policy replica count at 3 #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -868,6 +868,10 @@ func (s *Store) CreateDatabase(name string) (*DatabaseInfo, error) { | |||
| return nil, fmt.Errorf("read: %s", err) | |||
| } | |||
|
|
|||
| if nodeN > 3 { | |||
There was a problem hiding this comment.
To be clear, we're only supporting 3 node clusters right now?
There was a problem hiding this comment.
No. This is the auto-created retention policy. It just caps the replication factor at 3 instead of using the number of nodes. You can manually create replication factors greater than 3 now.
There was a problem hiding this comment.
Ah, OK, cool.
Not a huge fan of the magic number. Can you lift it up to MaxAutocreateRPFactor or something?
|
+1 on green build. |
Defaulting to the number of nodes in the cluster is doesn't make sense with larger clusters. (e.g. 10 nodes = RF 10)
jwilder
added a commit
that referenced
this pull request
Aug 12, 2015
Cap auto-created retention policy replica count at 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulting to the number of nodes in the cluster is doesn't make
sense with larger clusters. (e.g. 10 nodes = RF 10)